On Wed, 31 Aug 2022 12:39:08 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Please review this simple conversion for the ProtectionDomainCacheTable from >> Old Hashtable to ResourceHashtable. There are specific tests for this table >> in test/hotspot/jtreg/runtime/Dictionary and >> serviceability/dcmd/vm/DictionaryStatsTest.java. >> Also tested with tier1-7. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Fix comments, add assert. src/hotspot/share/classfile/protectionDomainCache.cpp line 186: > 184: > 185: // The object_no_keepalive() call peeks at the phantomly reachable oop > without > 186: // keeping it alive. This is used for traversing DictionaryEntry pd_set. My confusion here was that the comment belonged to the `ProtectionDomainCacheEntry::object_no_keepalive` method, but you have deleted that and are now applying the comment to the `ProtectionDomainEntry::object_no_keepalive()` method. The end result is okay. ------------- PR: https://git.openjdk.org/jdk/pull/10043
