On Tue, 30 Aug 2022 18:17:28 GMT, Bill Huang <d...@openjdk.org> wrote:
>> This task convert 3 shell tests below to java version.
>> test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh
>> test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
>> test/sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh
>
> Bill Huang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Relax line-length limit restriction
> - Implemented review comments.
Marked as reviewed by lmesnik (Reviewer).
test/jdk/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java line 206:
> 204: }
> 205: FileInputStream fin = new FileInputStream(passwordFileName);
> 206: try {
You could use try with resources.
test/jdk/sun/management/jmxremote/bootstrap/RmiTestBase.java line 172:
> 170: } else {
> 171: if (!thisEntry.principal().getName().contains("NULL
> SID") &&
> 172: thisEntry.type() != AclEntryType.ALLOW) {
I think the previous indentation was correct. We put "&&", "+" and "." in the
beginning of next line usually.
-------------
PR: https://git.openjdk.org/jdk/pull/9973
