On Mon, 29 Aug 2022 22:11:38 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> This task convert 3 shell tests below to java version.
>> test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh
>> test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh
>> test/sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh
>
> test/jdk/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java line 115:
>
>> 113: throws IOException {
>> 114:
>> 115: final Set names = server.queryNames(pattern, query);
>
> Since you change these lines, might add template parameters here?
> Set<ObjectName> names = ...
> and simplify if it is possible.
> Not a request, just a proposal.
Actually, I didn't make changes to these lines. They were done by the IDEA auto
formatter. But I can simplify it and add template parameters.
> test/jdk/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java line 166:
>
>> 164: if (args.length == 0) {
>> 165: throw new IllegalArgumentException("Argument is required
>> for this" +
>> 166: " test");
>
> not needed to split lines
The IDEA splits the lines for a line limit of 80 characters.
-------------
PR: https://git.openjdk.org/jdk/pull/9973
