On Thu, 14 Jul 2022 23:01:50 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed othervm option and fixed @requires coding style. > > The variables should use camelCase. Like min_count_for_pass -> > minCountForPass > Variable trace not needed, just print count always > The mention of Solaris should be removed from comments, also I don't know if > instructions for manual testing are needed, but it would be better to say "to > know actual value run smth". @lmesnik I've completely removed the comments for manual tests because I don't think manual tests are necessary in this scenario. If the purpose of the tests is to compare FD count from the Java API to the system properties, it can be done in automated tests. Potential test cases could be opening a new file and observing the opened FD count for increment, or checking the value from the system call. We can address this in a separate ticket if we want. ------------- PR: https://git.openjdk.org/jdk/pull/9503
