On Thu, 14 Jul 2022 21:56:57 GMT, Bill Huang <d...@openjdk.org> wrote:

> This is a task to convert shell tests to Java tests. The shell scripts to be 
> removed are responsible for compiling Java files and running the tests on 
> Linux systems. This functionality can be achieved with JTReg tag @requires 
> (os.family=="linux").

test/jdk/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.java
 line 29:

> 27:  * @summary Basic unit test of 
> UnixOperatingSystemMXBean.getMaxFileDescriptorCount()
> 28:  * @author  Steve Bohne
> 29:  * @requires (os.family=="linux")

please add spaces, braces are not required, see examples in jtreg tests
@requires os.family == "linux"

test/jdk/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.java
 line 31:

> 29:  * @requires (os.family=="linux")
> 30:  *
> 31:  * @run main/othervm GetMaxFileDescriptorCount

is othervm required here?

-------------

PR: https://git.openjdk.org/jdk/pull/9503

Reply via email to