On Fri, 8 Jul 2022 22:53:49 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Do not remove Forte::register_stub as it is used on Linux as well
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2700:
> 
>> 2698:     if (JvmtiExport::should_post_dynamic_code_generated()) {
>> 2699:       JvmtiExport::post_dynamic_code_generated(blob_id, 
>> new_adapter->content_begin(), new_adapter->content_end());
>> 2700:     }
> 
> The lines 2698-2670 is better to move out of the if-statement at the line 
> 2687.

HI Serguei, thanks for the review. Lines 2698-2700 need the blob_id which is 
generated at line 2688, so they have to stay inside the outer "if" block.

-------------

PR: https://git.openjdk.org/jdk/pull/9386

Reply via email to