On Sat, 2 Jul 2022 06:30:13 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> This fixes a bug in the debug agent when there is a request to suspend a 
>> virtual thread that has already terminated. The issue was that unless the 
>> debug agent was currently under a "suspend all", it would not properly put 
>> the virtual thread on the `otherThreads` list, and instead added it to 
>> `runningVThreads`. This meant at the end of `insertThread()` the following 
>> code tried to do a JVMTI `SetThreadLocalStorage`, which can't be done on a 
>> terminated thread.
>> 
>> 
>>         if (list != &otherThreads) {
>>             setThreadLocalStorage(node->thread, (void*)node);
>>         }
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Rename thread to targetThread. Verify targetThread state when the thread 
> dies and when the breakpoint after the join() is reached.

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.org/jdk19/pull/88

Reply via email to