On Wed, 22 Jun 2022 16:48:33 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8135291: Removed duplicate code in <OS>Address.java and related files in SA
>> -After asLongValue() added to interface Address.java, there no need to
>> have the getValue() in every instance Address.java
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java
> line 528:
>
>> 526: public long getAddressValue(Address addr) {
>> 527: if (addr == null) return 0;
>> 528: return (addr.asLongValue());
>
> Style nit: Omit the surrounding parenthesis: `return addr.asLongValue();`
> This repeats a couple of times.
Sure I will make that change.
-------------
PR: https://git.openjdk.org/jdk/pull/9112
