On Thu, 9 Jun 2022 19:19:44 GMT, Jayashree Huttanagoudar <d...@openjdk.org> wrote:
> This PR is to address : > https://bugs.openjdk.org/browse/JDK-8135292?jql=labels%20%3D%20starter-bug > Verified the build before and after the patch. Also below tests are run: > Before Patch: > > $ make test TEST="jtreg:test/hotspot/jtreg/serviceability" > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL > ERROR > >> jtreg:test/hotspot/jtreg/serviceability 316 314 1 > 1 << > ============================== > TEST FAILURE > > > After Patch: > > $ make test TEST="jtreg:test/hotspot/jtreg/serviceability" > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL > ERROR > >> jtreg:test/hotspot/jtreg/serviceability 316 314 1 > 1 << > ============================== > TEST FAILURE There are also SA tests in `test/jdk/sun/tools/jhsdb` that should be run. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java line 528: > 526: public long getAddressValue(Address addr) { > 527: if (addr == null) return 0; > 528: return ((BsdAddress) addr).asLongValue(); `asLongValue()` is declared in `Address`, so it should not be necessary to cast to a `BsdAddress` (and there are similar casts in the changes below that can be removed). ------------- PR: https://git.openjdk.org/jdk/pull/9112
