On Fri, 1 May 2026 19:29:05 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional data cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 171:
>
>> 169: * @return this builder
>> 170: * @throws IllegalArgumentException
>> 171: * if {@code m} is less than 8 or less than 8 * {@code
>> p} if
>
> s/if/; or if/ (2nd instance of if)
Will fix.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 172:
>
>> 170: * @throws IllegalArgumentException
>> 171: * if {@code m} is less than 8 or less than 8 * {@code
>> p} if
>> 172: * {@code parallelism(p)} is already called.
>
> s/is already/has already been/
Will fix.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 183:
>
>> 181: * Set the memory value to the builder in power of two.
>> 182: *
>> 183: * @param mPower set memory value to 2^{@code mPower} Kibibytes
>
> remove "set".
Will fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3439215435
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3439216176
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3439217300
