On Fri, 17 Apr 2026 15:01:44 GMT, Weijun Wang <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional data cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 228:
>
>> 226:
>> 227: /**
>> 228: * Set tagLen value to the builder.
>
> You want to use `tagLen` directly here?
Will change to "Sets the output tag length, in bytes." to match other methods
better.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 286:
>
>> 284: /**
>> 285: * Use the specified {@code salt}, {@code password} and the
>> supplied
>> 286: * parameters to create an Argon2ParameterSpec object.
>
> Quote "Argon2ParameterSpec" inside `{@code}`.
Yes.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 308:
>
>> 306: /**
>> 307: * Convert {@code passwdChar} to {@code byte[]} based on the
>> 308: * {@code cs}. Then use it with the specified {@code salt} to
>
> No need "the" before "cs". Do you also need to include "and the supplied
> parameters" to be consistent with the other `build` method?
Will update this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3439364587
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3439368131
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3439372461
