On Tue, 14 Jul 2026 12:23:34 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated to address review comments.
>
> src/java.base/share/classes/sun/security/provider/ByteArrayAccess.java line
> 41:
>
>> 39: * This class may also be helpful in improving the performance of the
>> 40: * crypto code in the SunJCE provider. However, for now it is only
>> accessible by
>> 41: * the message digest implementation in the SUN provider.
>
> This sentence starting with "However" seems outdated now.
Will remove.
> src/java.base/share/classes/sun/security/provider/ByteArrayAccess.java line
> 213:
>
>> 211: //
>> 212: //static long b2lLittle8(byte[] in, int inOfs) {
>> 213: // return (long) LE.LONG_ARRAY.get(in, inOfs);
>
> Remove?
Ok.
> test/jdk/javax/crypto/spec/Argon2ParameterSpec/InvalidArgs.java line 28:
>
>> 26: * @library /test/lib
>> 27: * @bug 8253914
>> 28: * @summary Ensure that Argon2ParameterSpec builder constructor throw the
>
> s/constructor/methods/
Yes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3707884833
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3707895982
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3707890255
