On Thu, 18 Jun 2026 12:54:18 GMT, Sean Mullan <[email protected]> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Split legacy alg detection from capturing the caller
>
> src/java.base/share/classes/java/security/KeyStore.java line 931:
> 
>> 929:      * the security property value.
>> 930:      *
>> 931:      * The JDK Reference Implementation additionally uses
> 
> Since there is now more than one property for this Implementation Note, I 
> think you should reword and change this to a bulleted-list just like the 
> `KeyStore.getInstance(String)` method, which already has more than one 
> property in its Implementation Note.
> 
> This comment applies to all the APIs in the PR.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31472#discussion_r3438659654

Reply via email to