On Thu, 18 Jun 2026 20:23:33 GMT, Hai-May Chao <[email protected]> wrote:
>> This change adds the `jdk.crypto.legacyAlgorithms` security property to >> `java.security`. At the JCE layer, the JDK checks this property and emits a >> runtime warning when a configured legacy algorithm is requested. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Sean's comments src/java.base/share/classes/java/security/KeyStore.java line 865: > 863: * <li>the {@code jdk.crypto.legacyAlgorithms} > 864: * {@link Security#getProperty(String) Security} property to > determine > 865: * if the specified keystore type is considered legacy. If so, it To be more precise, I would say "If so, a warning is emitted at runtime when this method is called with the keystore type." This comment applies to all getInstance methods in this PR. src/java.base/share/classes/java/security/KeyStore.java line 866: > 864: * {@link Security#getProperty(String) Security} property to > determine > 865: * if the specified keystore type is considered legacy. If so, it > 866: * emits a warning when the keystore type is requested. Please add these sentences after this: "This warning is shown once per caller for each legacy keystore type. If the keystore type is also disabled, the warning will not be shown." This comment applies to all `getInstance` methods in this PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31472#discussion_r3453212419 PR Review Comment: https://git.openjdk.org/jdk/pull/31472#discussion_r3453187264
