On Thu, 21 May 2026 20:21:07 GMT, Erik Joelsson <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2754 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - Merge >> >> Merge jdk-27+24 >> - 8385674: [lworld] TestNullableInlineTypes.java fails after JDK-8325632 >> >> Reviewed-by: mchevalier >> - 8385652: [lworld] RedefineClasses should use stack map frame name >> >> Reviewed-by: fparain >> - 8384107: [lworld] Update runtime/contended tests to run the same testing >> for value classes >> >> Reviewed-by: fparain, lmesnik >> - 8385600: [lworld] DA/DU issues with strict fields >> >> Reviewed-by: vromero >> - 8384897: [lworld] this.staticField should be restricted in early >> construction context >> >> Reviewed-by: liach, vromero >> - 8385601: [lworld] Update testing documentation for the ValueClassPlugin >> jtreg option >> >> Reviewed-by: lmesnik >> - 8385569: [lworld] Apply JDK-8343767 to Valhalla specific StubRoutines >> >> Reviewed-by: fparain, vlivanov >> - 8385581: [lworld] Remove the experimental JVMCI feature >> 8382708: [lworld] JVMCI support for Value Objects >> 8372605: [lworld] >> compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJava*.java >> fail with --enable-preview >> >> Reviewed-by: thartmann >> - ... and 2744 more: https://git.openjdk.org/jdk/compare/2c7efc08...9e804255 > > make/RunTests.gmk line 889: > >> 887: $1_JTREG_BASIC_OPTIONS += -vmoption:--enable-preview >> 888: $1_JTREG_BASIC_OPTIONS += -javacoption:-XDaccessInternalAPI >> 889: $1_JTREG_BASIC_OPTIONS += -javacoption:--source >> -javacoption:$(VERSION_FEATURE) > > Is this really necessary? Wouldn't the current feature version be the default > value for `--source`, or is there some interaction with --enable-preview that > requires it to be paired with `--source`? Yes, I think it is necessary. javac may default to the current source level normally, but once --enable-preview is present, javac requires the source level to be explicit. Otherwise it exits with: error: --enable-preview must be used with either -source or --release ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3350488759
