On Thu, 21 May 2026 16:38:33 GMT, Erik Joelsson <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2754 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - Merge >> >> Merge jdk-27+24 >> - 8385674: [lworld] TestNullableInlineTypes.java fails after JDK-8325632 >> >> Reviewed-by: mchevalier >> - 8385652: [lworld] RedefineClasses should use stack map frame name >> >> Reviewed-by: fparain >> - 8384107: [lworld] Update runtime/contended tests to run the same testing >> for value classes >> >> Reviewed-by: fparain, lmesnik >> - 8385600: [lworld] DA/DU issues with strict fields >> >> Reviewed-by: vromero >> - 8384897: [lworld] this.staticField should be restricted in early >> construction context >> >> Reviewed-by: liach, vromero >> - 8385601: [lworld] Update testing documentation for the ValueClassPlugin >> jtreg option >> >> Reviewed-by: lmesnik >> - 8385569: [lworld] Apply JDK-8343767 to Valhalla specific StubRoutines >> >> Reviewed-by: fparain, vlivanov >> - 8385581: [lworld] Remove the experimental JVMCI feature >> 8382708: [lworld] JVMCI support for Value Objects >> 8372605: [lworld] >> compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJava*.java >> fail with --enable-preview >> >> Reviewed-by: thartmann >> - ... and 2744 more: https://git.openjdk.org/jdk/compare/2c7efc08...9e804255 > > make/test/BuildTestLib.gmk line 65: > >> 63: HEADERS := $(TEST_LIB_SUPPORT)/test-lib_headers, \ >> 64: JAR := $(TEST_LIB_SUPPORT)/test-lib.jar, \ >> 65: DISABLED_WARNINGS := try deprecation rawtypes unchecked serial cast >> removal preview restricted varargs dangling-doc-comments, \ > > Break line, but maybe also consider improving the code quality of the new > test lib classes? That's a lot of disabled warning classes. See the following bug comment for my analysis: https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884501&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884501 Summary: The fix for [JDK-8347840](https://bugs.openjdk.org/browse/JDK-8347840) removed that variable specification in build jdk-25+7, but the merge into repo-valhalla kept that change for some reason. I need to try removing it in the current repo-valhalla and do some test builds to see if there is any breakage. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3349844394
