On Tue, 28 Oct 2025 20:24:36 GMT, Jamil Nimeh <[email protected]> wrote:
>> Good catch! That's how we do it throughout SSL code and I just followed that >> :) Coincidently, I recently was thinking why we need to do all these checks >> every time we log, instead we can specify the log options as a parameter. >> And here I have just found `SSLLogger.logWarning` method that does just that. > > I agree, it would be nice to at least have a single method that does the > enabled-or-not checking and can have the look and feel of either a println or > a format. But that's something to be done in another fix. If you want to > leave it as-is to follow convention I'm fine with that, and we can examine a > friendlier way to do logging separately. Sounds good! I'll use `SSLLogger.logWarning` here and we can deal with logging separately. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27961#discussion_r2471070211
