On Mon, 27 Oct 2025 15:19:30 GMT, Artur Barashev <[email protected]> wrote:
>> We need to address the following inconsistencies in
>> SSLConfiguration#getSSLParameters() call:
>> - For the signatureSchemes we return only what's been set by the user, the
>> default values are not being returned like for other SSLParameters.
>> - namedGroups return value is not being filtered against algorithm
>> constraints, unlike other SSLParameters.
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Log unavailable configured signature scheme
src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 427:
> 425: var ss = SignatureScheme.nameOf(name);
> 426: if (ss == null && SSLLogger.isOn
> 427: && SSLLogger.isOn("ssl,handshake")) {
Do you need both `SSLLogger.isOn` and the isOn check for ssl,handshake? The
latter check appears to only return true if it is both on and those flags have
been set.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27961#discussion_r2470709609
