On Wed, 27 Aug 2025 13:55:29 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address Sean's comments
>
> src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 304:
>
>> 302: * @return a new {@code HPKEParameterSpec} object
>> 303: * @throws NullPointerException if {@code psk_id} is {@code null}
>> 304: * @throws InvalidAlgorithmParameterException if {@code psk} and
>> {@code psk_id} are
>
> Why not throw `IllegalArgumentException` here instead?
Yes, you're right. This is still during constructing the a parameter. Will fix
it. I'll update the test as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2304509263
