On Tue, 26 Aug 2025 16:01:34 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> >> <img >> src="https://github.com/user-attachments/assets/45625334-903b-4a3d-a987-7fddeab9a604"; >> /> > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > address Sean's comments src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 304: > 302: * @return a new {@code HPKEParameterSpec} object > 303: * @throws NullPointerException if {@code psk_id} is {@code null} > 304: * @throws InvalidAlgorithmParameterException if {@code psk} and > {@code psk_id} are Why not throw `IllegalArgumentException` here instead? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2304018944
