On Tue, 1 Jul 2025 22:42:11 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated test per 2nd round of Mikhail's review comments. > > src/java.base/share/classes/javax/crypto/Cipher.java line 479: > >> 477: list.add(new Transform(parts[0], "//" + parts[2], parts[1], >> null)); >> 478: list.add(new Transform(parts[0], "", parts[1], parts[2])); >> 479: return list; > > Does this need to be immutable or does it not matter? It's only used internally within the Cipher class, so I don't think it matters, but we can use the `List.of()` to construct it as well for consistency. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25808#discussion_r2179357215
