On Tue, 17 Jun 2025 10:21:42 GMT, Mikhail Yankelevich
<myankelev...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated test per Mikhail's review comments.
>
> test/jdk/javax/crypto/Cipher/TestEmptyModePadding.java line 37:
>
>> 35: import javax.crypto.*;
>> 36:
>> 37: public class TestEmptyModePadding {
>
> Could you please change the imports to not use wildcard imports
>
>
>
> import java.security.NoSuchAlgorithmException;
> import java.security.Provider;
> import java.security.Security;
> import javax.crypto.Cipher;
Sure, I can do this.
> test/jdk/javax/crypto/Cipher/TestEmptyModePadding.java line 45:
>
>> 43: System.out.println("Testing against " + provider.getName());
>> 44:
>> 45: String[] testTransformations = {
>
> minor: Do you think it would be easier to read if each entry was a separate
> line?
I am ok either way, sounds like you prefer one line per entry. I can change
them.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25808#discussion_r2153729356
PR Review Comment: https://git.openjdk.org/jdk/pull/25808#discussion_r2153731933
