On Mon, 19 May 2025 22:24:52 GMT, Jamil Nimeh <jni...@openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> get*() no longer needed, backout error (oops!) > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1672: > >> 1670: // RFC 5705, "If no context is provided, ..." >> 1671: seed[pos++] = (byte) ((context.length >> 8) & 0xFF); >> 1672: seed[pos++] = (byte) ((context.length) & 0xFF); > > Because you're doing a primitive narrowing conversion down to a byte I don't > think you need the 0xFF masking. No, not required. `java.lang.Integer.byteValue()` does exactly this. But I was thinking to leave so the intent was clear. We talked, and will leave for now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24976#discussion_r2098882406
