On Thu, 29 May 2025 00:39:30 GMT, Bradford Wetmore <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comments. Optimize imports.
>
> test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java line 107:
>
>> 105:
>> 106: switch (testMode) {
>> 107: case BASIC:
>
> Minor nit, Oracle Code Style is (was?) to keep case at the same level as the
> switch. I noticed this was updated in all the different cases here.
>
> If you're using IJ, you'll need to set the Settings->Editor->Code
> Style->Java->switch statement/expression->Indent case branches
Could you please post a link to the guide where it says so? I've found a couple
of Oracle examples and both use different switch/case levels:
1. https://docs.oracle.com/javase/tutorial/java/nutsandbolts/switch.html
2.
https://docs.oracle.com/en/java/javase/17/language/switch-expressions-and-statements.html
Also, I couldn't find a single occurrence of the same switch/case level in our
SSL code. `SSLKeyExchange.java` for example has multiple switch/case statement
- all indented.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25310#discussion_r2113031202
