On Mon, 3 Mar 2025 15:57:49 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> >>  > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add mode_auth and mode_auth_psk, tiny spec change src/java.base/share/classes/sun/security/util/SliceableSecretKey.java line 1: > 1: /* I'm not used to the javadoc markdown `///` syntax. Maybe I'll get used to it, but is there a reason you are using it in internal classes? src/java.base/share/classes/sun/security/util/SliceableSecretKey.java line 29: > 27: import javax.crypto.SecretKey; > 28: > 29: /// An interface for `SecretKey`s that supports using its slice as a new s/supports/support/ src/java.base/share/classes/sun/security/util/SliceableSecretKey.java line 32: > 30: /// `SecretKey`. > 31: /// > 32: /// This is mainly used by PKCS #11 implementations that supports the s/supports/support/ ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r1990047332 PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r1990036780 PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r1990037201
