On Wed, 5 Mar 2025 14:45:34 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Please review this PR which provides localization updates for resources in
>> `jarsigner` and `keytool`.
>> The key/vals in this PR are updated to match the changes made in the English
>> source files.
>> Further context is provided on the JBS issue.
>
> src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
> line 312:
>
>> 310: "\u6B63\u5728\u4E3A {3}
>> \u751F\u6210\u6709\u6548\u671F\u4E3A {2} \u5929\u7684 {0}
>> \u5BC6\u94A5\u5BF9\u548C\u81EA\u7B7E\u540D\u8BC1\u4E66 ({1})\n"},
>> 311:
>> {"Generating.full.keyAlgName.key.pair.and.a.certificate.sigAlgName.issued.by.signerAlias.with.a.validity.of.days.for",
>> 312: "\u751F\u6210 {0} \u5BC6\u94A5\u5BF9\u548C <{2}>
>> \u9881\u53D1\u7684\u8BC1\u4E66 ({1})\uFF0C\u6709\u6548\u671F\u4E3A {3}
>> \u5929 \n\t \u5BF9\u4E8E\uFF1A{4}"},
>
> Why not make the two strings consistent?
>
> I think the 1st one "正在为 {3} 生成有效期为 {2} 天的 {0} 密钥对和自签名证书 ({1})\n" is very
> good, and suggest the 2nd one to be "正在为 {4} 生成有效期为 {3} 天的 {0} 密钥对和由 <{3}>
> 颁发的证书 ({2})\n".
As we discussed, we'll address any translation quality improvements in the
JDK25 L10N drop.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23911#discussion_r1981924963
