On Wed, 5 Mar 2025 00:23:51 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which provides localization updates for resources in
> `jarsigner` and `keytool`.
> The key/vals in this PR are updated to match the changes made in the English
> source files.
> Further context is provided on the JBS issue.
src/java.base/share/classes/sun/security/tools/keytool/Resources_de.java line
310:
> 308: "%1$d-Bit %2$s"},
> 309:
> {"Generating.full.keyAlgName.key.pair.and.self.signed.certificate.sigAlgName.with.a.validity.of.days.for",
> 310: "Schl\u00FCsselpaar {0} und selbstsigniertes Zertifikat
> ({1}) werden mit einer G\u00FCltigkeit von {2} Tagen generiert\n\tf\u00FCr:
> {3}"},
Putting `{0}` (which is size and type) after "Schlüsselpaar" sounds strange. I
understand you don't want to put `{0}` in parentheses because the value itself
might contain parentheses (For example, `384-Bit EC (secp384r1)`). Maybe we can
add a "mit" in between?
Also, Why change from active voice in the present continuous tense to passive
voice in the simple present tense?
src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
line 312:
> 310: "\u6B63\u5728\u4E3A {3}
> \u751F\u6210\u6709\u6548\u671F\u4E3A {2} \u5929\u7684 {0}
> \u5BC6\u94A5\u5BF9\u548C\u81EA\u7B7E\u540D\u8BC1\u4E66 ({1})\n"},
> 311:
> {"Generating.full.keyAlgName.key.pair.and.a.certificate.sigAlgName.issued.by.signerAlias.with.a.validity.of.days.for",
> 312: "\u751F\u6210 {0} \u5BC6\u94A5\u5BF9\u548C <{2}>
> \u9881\u53D1\u7684\u8BC1\u4E66 ({1})\uFF0C\u6709\u6548\u671F\u4E3A {3} \u5929
> \n\t \u5BF9\u4E8E\uFF1A{4}"},
Why not make the two strings consistent?
I think the 1st one "正在为 {3} 生成有效期为 {2} 天的 {0} 密钥对和自签名证书 ({1})\n" is very good,
and suggest the 2nd one to be "正在为 {4} 生成有效期为 {3} 天的 {0} 密钥对和由 <{3}> 颁发的证书
({2})\n".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23911#discussion_r1981516207
PR Review Comment: https://git.openjdk.org/jdk/pull/23911#discussion_r1981546844
