On Wed, 13 Nov 2024 15:12:24 GMT, Roger Riggs <[email protected]> wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove osName and osArch fields from Config.
>> Remove getValue method from P11KeyAgreement.
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java line 72:
>
>> 70: }
>> 71: osName = System.getProperty("os.name");
>> 72: osArch = System.getProperty("os.arch");
>
> osName and osArch seem to be unused; they could be removed but might be out
> of scope for this PR.
Good spot; I removed them - I'm ok with making small changes as long as they
are within the scope of the code being modified.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22077#discussion_r1841105708
