On Wed, 16 Oct 2024 00:11:15 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> running the Exhaustive test through a more ruthless formatter > > test/jdk/com/sun/crypto/provider/KDF/HKDFExhaustiveTest.java line 29: > >> 27: * @summary KDF API tests >> 28: * @library /test/lib >> 29: * @run main/othervm -Djava.security.egd=file:/dev/urandom >> -Djava.security.debug=provider,engine=kdf HKDFExhaustiveTest > > Not sure how helpful it is to set the debug option > "-Djava.security.debug=..." by default. Maybe remove it for regular test run? It is set by default at @rhalade's request. It will ensure test coverage tools travel down those code paths. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1802232304