On Tue, 15 Oct 2024 21:42:14 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test case formatting changes, etc > > test/jdk/com/sun/crypto/provider/KDF/HKDFKnownAnswerTests.java line 113: > >> 111: int testsPassed = 0; >> 112: >> 113: int testNo = 0; > > Why not also use `null` for `salt` as well? See the API docs. `null` is not a valid input to `addSalt`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1802066332
