On Wed, 23 Oct 2024 21:33:51 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused method > > src/java.base/share/classes/com/sun/crypto/provider/HKDFKeyDerivation.java > line 49: > >> 47: * <p> >> 48: * This class implements the HKDF-Extract and HKDF-Expand functions from >> RFC >> 49: * 5869. This implementation provides the complete Extract-then-Expand >> HKDF > > Do we need to provide link for RFC 5869 and add the @spec tag as in the PR > for JDK-8305406? Just a heads up, we can return to this in the future. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1817407158
