On Fri, 11 Oct 2024 19:52:32 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are 
>> only named standardized parameter sets, a common framework is introduced.
>> 
>> A example of EdDSA implementation using this framework is included as a test.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   some references, one typo

src/java.base/share/classes/sun/security/provider/NamedKEM.java line 217:

> 215:     ///
> 216:     /// @param name parameter name
> 217:     /// @param sk public key in raw bytes

nit: should be "private" key.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1797420209

Reply via email to