On Fri, 11 Oct 2024 16:34:51 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are 
>> only named standardized parameter sets, a common framework is introduced.
>> 
>> A example of EdDSA implementation using this framework is included as a test.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   describe a limitation of this framework

src/java.base/share/classes/sun/security/provider/NamedKeyPairGenerator.java 
line 103:

> 101: /// like EdDSA and XDH have been generating keys implementing `EdECKey` 
> or
> 102: /// `XECKey` interfaces, and they are not rewritten with this framework.
> 103: /// `NamedParamterSpec` fields not implemented with this framework 
> include

Typo: s/NamedParamterSpec/NamedParameterSpec/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1797318538

Reply via email to