On Fri, 13 Sep 2024 16:23:40 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creating a new .SF file, only include signed >> file entries.~ >> >> *Update*: Even when the JAR file is re-signed, the hash entry for the >> missing file will be in the new .SF file. There is no way to tell if this is >> for a file entry or a user-defined entry. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > remove another entry Marked as reviewed by hchao (Committer). Thanks for adding more testcases for this PR. Changes look good. ------------- PR Review: https://git.openjdk.org/jdk/pull/19599#pullrequestreview-2303694430 PR Comment: https://git.openjdk.org/jdk/pull/19599#issuecomment-2349572860