On Thu, 12 Sep 2024 16:01:13 GMT, Nibedita Jena <d...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test enhancements > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java > line 167: > >> 165: {"history.with.ts", "- Signed by \"%1$s\"\n Digest >> algorithm: %2$s\n Signature algorithm: %3$s, %4$s\n Timestamped by >> \"%6$s\" on %5$tc\n Timestamp digest algorithm: %7$s\n Timestamp >> signature algorithm: %8$s, %9$s"}, >> 166: {"history.without.ts", "- Signed by \"%1$s\"\n Digest >> algorithm: %2$s\n Signature algorithm: %3$s, %4$s"}, >> 167: {"history.nonexistent.entries", " Warning: nonexistent >> signed entries: "}, > > Inline with existing warning message, can it be "WARNING: Nonexistent signed > entries: " This warning is a part of a block on signer info and I'd like the word does not stand out too much. For example, the test shows: - Signed by "CN=x" Digest algorithm: SHA-384 Signature algorithm: Ed25519, 255-bit key Warning: nonexistent signed entries: [a] ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19599#discussion_r1757177373