On Wed, 11 Sep 2024 23:06:40 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are 
>> cryptographic algorithms for deriving additional keys from a secret key and 
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   further review comment changes

src/java.base/share/classes/javax/crypto/KDF.java line 222:

> 220:      * See also the Cipher Transformations section of the {@extLink
> 221:      * security_guide_jdk_providers JDK Providers} document for 
> information
> 222:      * on the transformation defaults used by JDK providers.

This sentence is specific to the Cipher API, it does not apply here and should 
be removed.

src/java.base/share/classes/javax/crypto/KDF.java line 339:

> 337:      * See also the Cipher Transformations section of the {@extLink
> 338:      * security_guide_jdk_providers JDK Providers} document for 
> information
> 339:      * on the transformation defaults used by JDK providers.

This sentence is specific to the Cipher API, it does not apply here and should 
be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1757571813
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1757572105

Reply via email to