On Tue, 27 Aug 2024 11:31:05 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code review comments and test renaming > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 244: > >> 242: * >> 243: * @param salt >> 244: * the salt value > > It's not clear that these are wrapped in`SecretKey` objects and returned in > the `salts()` method of `Extract` and `ExtractThenExpand` - I think that > detail needs to be noted in the API, otherwise users might find it > surprising. Same comment for `addIKM(byte[])`. Addressed in https://github.com/openjdk/jdk/pull/20301/commits/e4400b6edaf69d08726a63e2a705784c731648db. Please confirm if resolved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1739436572
