On Wed, 28 Aug 2024 22:42:50 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> This wording was suggested by another reviewer, since the implementation is >> not truly "returned" at this point (ie - a provider may not have been >> selected, if the provider is not passed as an argument). Saying that the >> instance is "initialized" with the algorithm is more accurate, since it >> returns an instance where the algorithm name is really all we would know at >> that point in time, unless the provider is specified. > > I find Sean's suggestion more accurate than the "initialized" word - even if > we have not selected the provider, the final choice should "implement" the > specified algorithm. Addressed in https://github.com/openjdk/jdk/pull/20301/commits/6b7a75da2ebb1cc9d95628018d756e2ce2162768. Please review and confirm if resolved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1739097455
