On Tue, 25 Jun 2024 23:14:38 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi, >> >> I need a review to change the a fragment buffer size miscalculation error. >> This appears when there are large handshake messages and hasn't been >> observed during application data. This was found during testing of the >> NewSessionTicket change in >> [JDK-8328608](https://bugs.openjdk.org/browse/JDK-8328608). There is no >> regression test as the failure hasn't shown to fail every time. >> >> thanks >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > updated changes Thanks for making the change. LGTM. > Is it possible to add a Test? I don't think it is possible; right now we flush after every handshake message. As a result, `count == position` every time we enter this loop, so the change doesn't really change anything. The problem only surfaced in #19465, and only when multiple NewSessionTicket messages exceeding 16KB were sent without flushing. ------------- Marked as reviewed by djelinski (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19862#pullrequestreview-2140881188
