On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > re-enable preview annotations src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 332: > 330: * @return the optional context and application specific > information > 331: */ > 332: public byte[] info() { I think the API docs will need to say that it returns a copy of the context/info, don't want readers to assume that an Expand object is mutable by way to modifying the byte[]. src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 383: > 381: > 382: /** > 383: * Returns the {@code List} of initial key material values. Can the ikms and salts method specify the ordering of the list? I assume it's the order that the material and sats were added but the API docs doesn't say this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598129595 PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598131216
