On Fri, 10 May 2024 12:12:06 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 467:
>> 
>>> 465:         ps("KDF", "HkdfSHA384",
>>> 466:                 
>>> "com.sun.crypto.provider.HkdfKeyDerivation$HkdfSHA384");
>>> 467:         ps("KDF", "HkdfSHA512",
>> 
>> In fact I like the old name better. At least I think the `HKDF` should be 
>> all capitals. Whether you need the `Hmac` word and what delimiter to use can 
>> be discussed.
>
> What about `HKDFWithHmacSHA256`? This would be consistent with previous PBE 
> names.

@seanjmullan, yes, I like that style.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1596850395

Reply via email to