On Fri, 10 May 2024 02:27:31 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding in delayed provider selection
>
> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 467:
>
>> 465: ps("KDF", "HkdfSHA384",
>> 466: "com.sun.crypto.provider.HkdfKeyDerivation$HkdfSHA384");
>> 467: ps("KDF", "HkdfSHA512",
>
> In fact I like the old name better. At least I think the `HKDF` should be all
> capitals. Whether you need the `Hmac` word and what delimiter to use can be
> discussed.
What about `HKDFWithHmacSHA256`? This would be consistent with previous PBE
names.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1596676867
