On Mon, 27 Nov 2023 20:21:33 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Code changes for HSS/LMS that's related to keytool and jarsigner:
>> 
>> 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it 
>> can only be `HSS/LMS`.
>> 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same 
>> as the hash algorithm used by the HSS/LMS key. This needs to be enforced 
>> both at signing and verification.
>> 3. HSS/LMS reuses `.DSA` as the signature block file extension inside a 
>> signed JAR file
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reword comment

src/java.base/share/classes/sun/security/pkcs/SignerInfo.java line 526:

> 524:                 break;
> 525:             case "HSS/LMS":
> 526:                 // RFC 8708 requires the same hash algorithm used as in 
> the HSS/LMS algorithm

Actually it is RFC 8554 that requires it, RFC 8708 just references RFC 8554

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14254#discussion_r1410904786

Reply via email to