On Thu, 16 Nov 2023 16:33:36 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> This internal method was called by `TimestampedSigner` which was removed >> long ago when we removed the support for `ContentSigner` and `jarsigner >> -altsign`. It has been useless for some time and this is just a cleanup. > > Ok, I see. It probably should have been removed as part of > https://bugs.openjdk.org/browse/JDK-8303410. So I'm ok with the cleanup. > > It probably makes sense to rename `newGenerateSignedData` to > `generateSignedData` (since there is only one method now). Good. I've done it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14254#discussion_r1396064310
