On Wed, 1 Nov 2023 05:01:18 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> test/jdk/javax/net/ssl/SSLSession/ResumeTLS13withSNI.java line 466:
>>
>>> 464: KeyManagerFactory kmf;
>>> 465:
>>> 466: try (FileInputStream fsIn = new FileInputStream(ksPath)) {
>>
>> No need for this `FileInputStream`.
>
> I left this due to the "try." I can remove if you prefer, but it seemed like
> it was better to leave in this check for the existence of the file due to the
> declared exception in the method signature.
I see what you mean, but in any of these tests, no matter if a FNFE or an IAE
is thrown, it's not handled and the test simply fails. I don't think it's worth
checking twice on the existence of the file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378811603
