On Tue, 31 Oct 2023 20:26:50 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
>
> Kevin Driver has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix indenting and wildcard imports
test/jdk/javax/net/ssl/SSLSession/ResumeTLS13withSNI.java line 442:
> 440: TrustManagerFactory tmf;
> 441:
> 442: try (FileInputStream fsIn = new FileInputStream(tsPath)) {
No need for this `FileInputStream`.
test/jdk/javax/net/ssl/SSLSession/ResumeTLS13withSNI.java line 466:
> 464: KeyManagerFactory kmf;
> 465:
> 466: try (FileInputStream fsIn = new FileInputStream(ksPath)) {
No need for this `FileInputStream`.
test/jdk/javax/net/ssl/SSLSession/SessionCacheSizeTests.java line 319:
> 317: KeyManagerFactory kmf = KeyManagerFactory.getInstance("SunX509");
> 318: KeyStore ks;
> 319: try (FileInputStream fis = new FileInputStream(keyFilename)) {
No need for this `FileInputStream`.
test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java
line 182:
> 180:
> 181: try (FileInputStream keyFile = new FileInputStream(keyFilename);
> 182: FileInputStream trustFile = new
> FileInputStream(trustFilename)) {
No need for these `FileInputStream`s.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378138741
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378138890
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378139194
PR Review Comment: https://git.openjdk.org/jdk/pull/16159#discussion_r1378140089
