On Wed, 5 Jul 2023 12:16:32 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add even more cases and tidy up > > src/java.base/share/classes/sun/security/provider/PolicyParser.java line 1133: > >> 1131: && Objects.equals(this.permission, that.permission) >> 1132: && Objects.equals(this.name, that.name) >> 1133: && Objects.equals(this.signedBy, that.signedBy); > > The original code also compared `action` Good catch; thanks! I have fixed this and the other bug you commented on in ca0d43a34ad. What's unpleasant is that tiers 1 and 2 didn't catch those bugs. One useful but separate from this PR exercise would be to gather code coverage for those tiers to see where we can improve our testing. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14738#discussion_r1253221129
