On Tue, 14 Mar 2023 14:30:21 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More space after catch
>
> src/java.base/share/classes/sun/net/www/protocol/http/Negotiator.java line 86:
>
>> 84: }
>> 85:
>> 86: public abstract void disposeContext() throws IOException;
>
> We have some old internal tests that extend `Negotiator` and that will fail
> when this change is pushed. I'd suggest to change this method as follows:
>
> Suggestion:
>
> public void disposeContext() throws IOException { }
>
>
> This should avoid breaking existing subclasses that do not implement this
> method.
Thank you. Changed from abstract to empty.
sun/security/jgss sun/security/krb5 sun/net/www/protocol/http tests passed
-------------
PR: https://git.openjdk.org/jdk/pull/12920
