On Mon, 13 Mar 2023 17:33:12 GMT, Alexey Bakhtin <abakh...@openjdk.org> wrote:
>> This patch fixes a possible native memory leak in case of a custom native >> GSS provider. >> The actual leak was reported in production. >> >> sun/security/jgss, sun/security/krb5, sun/net/www/protocol/http jtreg tests >> are passed > > Alexey Bakhtin has updated the pull request incrementally with one additional > commit since the last revision: > > More space after catch src/java.base/share/classes/sun/net/www/protocol/http/Negotiator.java line 86: > 84: } > 85: > 86: public abstract void disposeContext() throws IOException; We have some old internal tests that extend `Negotiator` and that will fail when this change is pushed. I'd suggest to change this method as follows: Suggestion: public void disposeContext() throws IOException { } This should avoid breaking existing subclasses that do not implement this method. ------------- PR: https://git.openjdk.org/jdk/pull/12920