On Wed, 8 Mar 2023 14:06:13 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> security.cpp contains a few invalid implicit conversions between pointer >> types that will not fly when the permissive- compiler option is active. >> Given that permissive- will become the Visual C++ compiler's default mode of >> operation in the future, it is better to handle this now so future compiler >> upgrades will not cause issues. Problems here are very easily solved with >> explicit casts > > permissive- is a pretty big problem for Windows code in general, in > particular our very jint and jlong typedefs themselves on Windows are > completely broken on Windows and compiling with permissive- will straight up > make the entire JDK explode. Change here is particular is a small part of a > much bigger (JDK wide) fix, if that's what you meant by it happening in other > files. I'm not sure if the code here could be redefined as a jchar from the > start though, should I give it a try? Hi @TheShermanTanker What complier are you using? What command line? `security.cpp` compiles just fine with `-permissive-` here, both debug and release. I'm using this compiler: >cl.exe Microsoft (R) C/C++ Optimizing Compiler Version 19.33.31629 for x64 Copyright (C) Microsoft Corporation. All rights reserved. you can find the cmdline under support/native/jdk.crypto.mscapi/libsunmscapi. ------------- PR: https://git.openjdk.org/jdk/pull/12907
